whats wrong with this code

Dev Articles Community Forums Sponsor:

September 10th, 2002, 01:57 AM

Mr Chocloate

Junior Member

Join Date: Aug 2002

Location: Anglesea

Posts: 12

Time spent in forums: < 1 sec
Reputation Power: 0

whats wrong with this code

I'm very tired can you help me. All i want to do is page the results of my query. Do you know how to do this? can you please fix my code?

my brain is fried. If you have a better way of doing this please show me

PHP Code:


		
			
<?php 

// entries per page 

$perpage = 5; 



$totalquery = "SELECT COUNT(*)"; 

$query = "SELECT DISTINCT Image1, Suburb, Caption, Description, Properties.ID, Price, SuburbID"; 

$from  = " FROM  Properties, Suburbs"; 

$where = " WHERE Properties.ID > 0 AND Hide='N' AND Sold='N' AND SuburbID=Suburbs.ID "; 



if ($buildid != "") { // An Suburb is selected 

  $where .= " AND BuildingID=$buildid"; 

} 



if ($suburbid != "") { // An Suburb is selected 

  $where .= " AND SuburbID=$suburbid"; 

} 



if ($agencyid != "") { // An Agency is selected 

  $where .= " AND PropertyAgencyID=$agencyid"; 

} 



if ($cid != "") { // A category is selected 

  $from  .= ", PropertyLookup"; 

  $where .= " AND Properties.ID=PID AND CID=$cid"; 

} 



if ($eid != "") { // A extra is selected 

  $from  .= ", PropertyExtras"; 

  $where .= " AND Properties.ID=PID AND EID=$eid"; 

} 



if ($min != "") { // Some search text was specified 

  $where .= " AND Bedrooms >= '$min'"; 

} 

if ($to != "") { // Some search text was specified 

  $where .= " AND Bedrooms < '$to'"; 

} 



if ($pricefrom != "") { // Some search text was specified 

  $where .= " AND Price >= '$pricefrom'"; 

} 

if ($priceto != "") { // Some search text was specified 

  $where .= " AND Price < '$priceto'"; 

} 



$totalquery .= $from .= $where; 



// get total entries in the db 

$test  = mysql_query($totalquery); 

$total = mysql_result($test, 0, 0); 



// calculate the number of pages 

$pageCount = ceil($total / $perpage); 



// display pages - now with first and last page 

echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=0\">[ first ]</a>&nbsp; "; 

for ($i = 0; $i < $pageCount; $i++) { 

   echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=$i\">[$i]</a>&nbsp; "; 

} 

echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=".($pageCount - 1)."\">[ last ]</a>&nbsp; "; 



if (!isset($HTTP_GET_VARS['page']) || $HTTP_GET_VARS['page'] < 0 || $HTTP_GET_VARS['page'] > $pageCount) { 

   $start = 0; 

} 

else { 

   $start = $perpage * $HTTP_GET_VARS['page']; 

} 



$query .= $from .= $where .= " LIMIT $start, $perpage"; 



// for testing: i get a line error here line 

echo "Totalquery = $totalquery <br>"; 

echo "Normalquery = $query <br>"; 



$query1 = mysql_query($query); 



// some testing output 

echo '<pre>'; 

while ($data = mysql_fetch_array($query1, MYSQL_ASSOC)) { 

    print_r($data); 

} 

echo '</pre>'; 



?>

you can see the result of this code here

http://www.sunet.com.au/~adcell/tes...0&submit=Search

Last edited by Mr Chocloate : September 10th, 2002 at 01:59 AM.

September 10th, 2002, 03:43 PM

adunsulag

Junior Member

Join Date: Sep 2002

Posts: 5

Time spent in forums: 1 m 32 sec
Reputation Power: 0

Give the part that is giving you the error

Could you please just give us a small section of where the error is?

September 10th, 2002, 07:03 PM

Mr Chocloate

Junior Member

Join Date: Aug 2002

Location: Anglesea

Posts: 12

Time spent in forums: < 1 sec
Reputation Power: 0

line 54:

PHP Code:


		
			
 $total = mysql_result($test, 0, 0);

And the sql query you can see the errors here

http://www.sunet.com.au/~adcell/tes...0&submit=Search

it just keeps repeating. thanks adunsulag for taking a look.

September 10th, 2002, 07:06 PM

Ben Rowe

Guest

Posts: n/a
Time spent in forums:
Reputation Power:

$query .= $from .= $where .= " LIMIT $start, $perpage";

that should be

$query = $query . $from . $where . " LIMIT $start, $perpage";

September 10th, 2002, 07:54 PM

Mr Chocloate

Junior Member

Join Date: Aug 2002

Location: Anglesea

Posts: 12

Time spent in forums: < 1 sec
Reputation Power: 0

Thank's Ben your a PHP machine! & Flash

one more question if you will? do you know why i lose my query string?my sever is using php 4.0.6 ? do you know another way to do PHP_SELF? whithout all this $HTTP_SERVER_VARS?

PHP Code:


		
			
echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=0\">[ first ]</a>&nbsp; "; 

for ($i = 0; $i < $pageCount; $i++) { 

   echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=$i\">[$i]</a>&nbsp; "; 

} 

echo "<a href=\"{$HTTP_SERVER_VARS['PHP_SELF']}?page=".($pageCount - 1)."\">[ last ]</a>&nbsp; "; 



if (!isset($HTTP_GET_VARS['page']) || $HTTP_GET_VARS['page'] < 0 || $HTTP_GET_VARS['page'] > $pageCount) { 

   $start = 0; 

} 

else { 

   $start = $perpage * $HTTP_GET_VARS['page']; 

}

September 10th, 2002, 09:24 PM

adunsulag

Junior Member

Join Date: Sep 2002

Posts: 5

Time spent in forums: 1 m 32 sec
Reputation Power: 0

$PHP_SELF;

why not just use $PHP_SELF?

September 10th, 2002, 10:37 PM

Mr Chocloate

Junior Member

Join Date: Aug 2002

Location: Anglesea

Posts: 12

Time spent in forums: < 1 sec
Reputation Power: 0

thanks for your help guys everything works great now.

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread: