|
Writing to file --> Please critique my code...
Hi all,
I'm fairly new to PHP code. And I would like experts' help in writing efficient code.
Following is a form, once filled, it writes configuration file, which in turn I'll use to include in file(s).
PHP Code:
// file: config_write.php
<?php
$title = "Configuration Writer";
$writefile = "data.txt";
?>
<html>
<head>
<title>/ <? echo $title; ?> /</title>
<style type="text/css">
<!--
html, body {
background-color: #EFEFEF;
margin: 40px;
}
.filecontent {
font-family: "Verdana", "Arial", "Helvetica", "sans-serif";
font-size: 10px;
line-height: 11px;
color: #006699;
width: 400px;
}
.mytext {
font-family: "Verdana", "Arial", "Helvetica", "sans-serif";
font-size: 12px;
color: #333333;
line-height: 18px;
width: 400px;
}
.mytext a:link {
color: #006699;
text-decoration: underline;
}
.mytext a:visited {
color: #006699;
text-decoration: underline;
}
.mytext a:hover {
color: #006699;
text-decoration: none;
}
.mytext a:active {
color: #006699;
text-decoration: underline;
}
.btn {
background: #006699;
color: #FFFFFF;
font-family: Verdana, Arial, Helvetica, sans-serif;
font-size: 11px;
margin: 3px;
}
.btnUp {
background: #CCCCCC;
color: #006699;
font-family: Verdana, Arial, Helvetica, sans-serif;
font-size: 11px;
margin: 3px;
}
.btnOver {
background: #006699;
color: #FFFFFF;
font-family: Verdana, Arial, Helvetica, sans-serif;
font-size: 11px;
margin: 3px;
}
.mytextarea {
background-color: #FFFFFF;
width: 400px;
padding: 6px;
margin: 3px;
border-left: solid 1px #333333;
border-top: solid 1px #333333;
border-right: solid 1px #CCCCCC;
border-bottom: solid 1px #CCCCCC;
color: #006699;
}
.mytextarea:focus {
color: #006699;
background: #FFFFCC;
}
-->
</style>
</head>
<body>
<form action="<? echo "$PHP_SELF"; ?>" method="post" class="mytext">
File: config_write_2.php<br><br>
Page title:<br>
<input type="text" name="formTitle" class="mytextarea"><br>
Company name:<br>
<input type="text" name="formCompname" class="mytextarea"><br>
Footer text:<br>
<input type="text" name="formFooter" class="mytextarea"><br>
<input type="submit" name="submit" value="Submit!" class="btnOver" onmouseover="this.className='btnUp'" onmouseout="this.className='btnOver'">
<input type="reset" name="reset" value="Reset!" class="btnOver" onmouseover="this.className='btnUp'" onmouseout="this.className='btnOver'">
</form>
<?php
$filePointer = fopen($writefile, "w+");
$title = $formTitle;
$compname = $formCompname;
$footer = $formFooter;
fputs($filePointer, "<?php\r\n", 1024);
fputs($filePointer, "/* copy configuration */\r\n");
fputs($filePointer, "// file title\r\n");
fputs($filePointer, "\t\$title = \"$title\";\r\n");
fputs($filePointer, "// company name\r\n");
fputs($filePointer, "\t\$compname = \"$compname\";\r\n");
fputs($filePointer, "// footer DIV text\r\n");
fputs($filePointer, "\t\$footer = \"$footer\";\r\n");
fputs($filePointer, "/* body behaviour */\r\n");
fputs($filePointer, "// onLoad\r\n");
fputs($filePointer, "\t\$onload = \"P7_alignWD2('bottomLayer',6,0,0,'bottomLayer',1,14 1,0);P7_autoLayers(0,'bottomLayer');flevInitPersis tentLayer('bottomLayer',1,'','','','','','',2);ini tSwipeMenu()\"\r\n");
fputs($filePointer, "?>\r\n");
fclose($filePointer);
?>
<?php
if (isset($title)) {
echo "<span class=\"mytext\"><hr noshade size=\"1\">";
echo "<font class=\"mytext\">
Information was written!!
<a href=\"$writefile\" onFocus=\"if(this.blur)this.blur()\" target=\"_blank\"> Preview file...</a> [new window]</font><br>";
echo "<hr noshade size=\"1\">\n";
echo "<span class=\"filecontent\">";
echo "File: <strong>data.txt</strong><br>\n";
// Get a file into an array.
// This example we'll go through HTTP to get HTML source of a URL.
$lines = file ($writefile);
// Loop through our array, show html source as html source;
// and line numbers too.
foreach ($lines as $line_num => $line) {
echo "<strong>Line #{$line_num}:</strong> " . htmlspecialchars($line) . "<br>";
}
// Another example, let's get a web page into a string. See also file_get_contents().
$html = implode ('', file ($writefile));
echo "<hr noshade size=\"1\"></span>";
}
?>
<?php
/*
$handle = fopen ("$writefile", "r");
while (!feof ($handle)) {
$buffer = fgets($handle, 4096);
echo $buffer;
}
fclose ($handle);
*/
?>
</body>
</html>
I look forward and welcome comments, critiques and suggestions...
Thankx in advance,
Arthur
|
Dev Articles Community Forums Sponsor:
February 9th, 2003, 04:41 PM
Del.icio.us
Digg
Google
Spurl
Blink
Furl
Simpy
Y! MyWeb
Linear Mode
