Die rolling program?

Dev Articles Community Forums Sponsor:

October 21st, 2009, 10:37 PM

lepetitchou

Registered User

Join Date: Oct 2009

Posts: 2

Time spent in forums: 1 h 2 m 39 sec
Reputation Power: 0

Die rolling program?

Hey everyone, I'm EXTREMELY new to Java. I've been working on two programs, the first gets and sets random numbers (1-6) and the second grabs the random numbers from the first program, then displays which of the two rolls is higher.

here's the first:

Code:

import java.util.*;
import java.util.Random;
public class Die 

{	
	private int value;
 		public int getRoll()
	{
	return value;
	}
		public void setRoll 
		(int HIGHEST_DIE_VALUE, int LOWEST_DIE_VALUE )
	{
	int value = ((int) (Math.random() * 100 ) % 6 + 1);
	}
}

the second is:

Code:

public class twoDice2 {

   	public static void main(String[] args)
	{
		int FirstRoll;
		int SecondRoll;	
		Die D = new Die();
		
		FirstRoll = D.getRoll();
		SecondRoll = D.getRoll();
		
		System.out.println("The first roll: " + FirstRoll );
		System.out.println("The second roll: " + SecondRoll );
		      
      if( FirstRoll == SecondRoll )
      {
              System.out.println("The dice are equal");
      }
      else
      	if( FirstRoll > SecondRoll )
      	{
      		System.out.println("Die one wins");
      	}
      else
      	if( FirstRoll < SecondRoll )
      	{
      		System.out.println("Die two wins");
      	}
}

They both compiled properly, but only show the rolls as always equal, and always 0.

Please help if you can, thanks!

October 27th, 2009, 12:54 PM

paulio84

Registered User

Join Date: Oct 2009

Posts: 2

Time spent in forums: 1 h 22 m 20 sec
Reputation Power: 0

Hello there,

The reason the result only returns zero (0) is because you never actually call the setRoll method when you set your new Die in the twoDice2 class. So therefore a random roll of the dice is never performed.

A quick fix would be to do this for your twoDice2 class

Code:

public class twoDice2 {

   	public static void main(String[] args)
	{
		int FirstRoll;
		int SecondRoll;	
		Die D = new Die();
		
                D.setRoll();
		FirstRoll = D.getRoll();
                D.setRoll();
		SecondRoll = D.getRoll();
		
		System.out.println("The first roll: " + FirstRoll );
		System.out.println("The second roll: " + SecondRoll );
		      
      if( FirstRoll == SecondRoll )
      {
              System.out.println("The dice are equal");
      }
      else
      	if( FirstRoll > SecondRoll )
      	{
      		System.out.println("Die one wins");
      	}
      else
      	if( FirstRoll < SecondRoll )
      	{
      		System.out.println("Die two wins");
      	}
}

Alternatively,

you could change the die class to just have one method to set and return the value (call the method doRoll or something) which would set the value just like setRoll and return it just like getRoll.

This way when you do

Code:

FirstRoll = D.getRoll();
SecondRoll = D.getRoll();

in your original code
you could now do

Code:

FirstRoll = D.doRoll();
SecondRoll = D.doRoll();

and then you should get two different numbers

HTH

Developer Shed Advertisers and Affiliates