I'm a nitpicker; Coding mistake in article 106

Programming Tools

User Name:

Password:

Remember me

Dev Articles Community Forums Sponsor:

Ajax Application Generator Generate database and reporting .NET Web apps in minutes. Quickly create visually stunning, feature-rich apps that are easy to customize and ready to deploy. Download Now!

May 13th, 2002, 04:00 PM

ejbe99

Contributing User

Join Date: May 2002

Posts: 43

Time spent in forums: 4 m 40 sec
Reputation Power: 7

I'm a nitpicker; Coding mistake in article 106

In this article it has an example of an e-mail validator.

PHP Code:


		
			
<?php 



function validateEmail($email) 

{ 

return ereg("^[a-zA-Z]+@[a-zA-Z]+\.[a-zA-Z]+$", $email); 

} 



echo validateEmail("mitchell@devarticles.com"); 



?>

That's bad code! What if someone has a number in their e-mail adress? Or an underscore? It would say their e-mail is invalid. I hope no one used this. Here's the real code:

PHP Code:


		
			
<?php 



function validateEmail($email) 

{ 

return ereg("^[a-zA-Z0-9_]+@[a-zA-Z0-9_]+\.[a-zA-Z0-9_]+$", $email); 

} 



echo validateEmail("mitchell@devarticles.com"); 



?>

I hope this isn't a waste of time, as in someone pointed this out already.

BTW: Mytch, you're doing a great job with the site

Last edited by ejbe99 : May 13th, 2002 at 04:53 PM.

May 13th, 2002, 06:02 PM

mytch

Join Date: Apr 2002

Location: Sydney, Australia

Posts: 589

Time spent in forums: < 1 sec
Reputation Power: 7

Hey,
Thanks for pointing that out, but the whole point of that was to get the readers familiar with regexp's.... not to actually validate ALL email addresses...it was to show how patterns work, but thanks for picking it out anyway.

May 15th, 2002, 10:46 PM

Ben Rowe

Guest

Posts: n/a
Time spent in forums:
Reputation Power:

If you really want to get picky, you can download php classes, which validate email addresses, and they work really well, if you want to validate emails, i sugest that you look for one of these classes, their really good

Viewing: Dev Articles Community Forums > Programming > Programming Tools > I'm a nitpicker; Coding mistake in article 106

« Previous Thread | Next Thread »

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump

Free IT White Papers!

Accelerating Trading Partner Performance
One in five. That's how many partner transactions have at least one error. That is an amazing statistic, particularly given the extraordinary leaps in innovation across the global supply chain during the past two decades. Download this white paper to learn more.

Competing on Analytics
This Tech Analysis is designed to help identify characteristics shared by analytics competitors, and includes information about 32 organizations that have made a commitment to quantitative, fact-based analysis.

Cost Effective Scaling with Virtualization and Coyote Point Systems
An overview of the industry trend toward virtualization, how server consolidation has increased the importance of application uptime and the steps being taken to integrate load balancing technology with virtualized servers.

Five Checkpoints to Implementing IP Telephony
Implementation planning for IP PBX software and IP telephony has become vital as businesses replace discontinued legacy PBX phone systems. This informative whitepaper outlines five "checkpoints" for any implementation plan that will help make IP communications a successful proposition.

Hosted Email Security: Staying Ahead of New Threats
In the last two years, email has become a fierce battleground between the nefarious forces of spam and malware, and the heroes of messaging protection. The spam volumes increased alarmingly every month, bringing clever new forms of phishing and virus propagation attacks.

More Free IT White Papers!