What do you think of my site?

Dev Articles Community Forums Sponsor:

February 28th, 2004, 11:02 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

What do you think of my site?

Hey all!
I've made an site in PHP and I'm curious what you think of it!
The url is:
http://spongy.kicks-ass.org/

__________________
Work to live, don't live to work

February 28th, 2004, 09:44 PM

MadCowDzz

I'm Internet Famous

Dev Articles Frequenter (2500 - 2999 posts)

Join Date: Jan 2003

Location: Toronto, Canada

Posts: 2,890

Time spent in forums: 1 Week 16 h 14 m 9 sec
Reputation Power: 8

Your site doesn't seem to load for me...
Are you sure you've typed the proper address?

February 29th, 2004, 07:05 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

I have a technical problem with the server right now... It is the proper address, so try again later. I'm working on it!

The server is fully operational again... Stupid keyboarderror...

The server is 1200 km away, so it's a bit hard to go there by myself. Luckily there's telephone!

Anyway, the site is up again so please try again to review!

Cheers,

Last edited by Spongy : February 29th, 2004 at 04:39 PM. Reason: Server is working again

March 8th, 2004, 09:21 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Not really a review yet... I'm really curious about your opinions!

March 10th, 2004, 04:28 PM

merliin

Contributing User

Join Date: Feb 2004

Location: Melbourne, Australia

Posts: 30

Time spent in forums: < 1 sec
Reputation Power: 5

I don't see why you need a frameset for it.
Didn't check to see if you're using a frameset or an iframe.
Either way, since it's php, use tables and make the menu and topbar into seperate
scripts and then just call them from the main script.
Ie:

Code:

<table>
  <tr>
    <td colspan=2><?php topbar(); ?></td>
  </tr>
  <tr>
    <td width=15%><?php menu(); ?></td>
    <td width=85%><?php mainpage(); ?></td>
  </tr>
</table>

Just my personal opinion as I think frames are generally an unnecessary evil.

__________________
MERLiiN
-------
Nastynerds.com - Development oriented site with snippets

March 10th, 2004, 06:41 PM

stumpy

May contain nuts.

Dev Articles Regular (2000 - 2499 posts)

Join Date: Aug 2002

Location: Sydney, AU

Posts: 2,058

Time spent in forums: 5 h 8 m 57 sec
Reputation Power: 9

Using tables for layout is semantically incorrect. Using standards based code, here's how you would layout the above site (using a tableless method)

Code:

<div id="topMenu"><?code?></div>
<div id="leftMenu"><?code?></div>
</div id="mainBody"><?code?></div>
<style type="text/css">
#leftMenu {
  float:left;
  width : 140px;
}

#mainBody {
  margin-left:140px;
}
</style>

__________________
DevArticles Moderator
BlueSix - Web Development and Consulting

March 11th, 2004, 07:45 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Thnx for the reply.
The site is running on an old template, I use an Iframe for it. I'm very busy designing a template based on XHTML with borderless design. So in the future you can review again

But Stumpy, is this correct?
</div id="mainBody"><?code?></div>
Or is it a typo at the first div-tag....

Cheers

March 11th, 2004, 08:51 AM

stumpy

May contain nuts.

Join Date: Aug 2002

Location: Sydney, AU

Posts: 2,058

Time spent in forums: 5 h 8 m 57 sec
Reputation Power: 9

Oops - typo!

Quote:

Originally Posted by Spongy

I'm very busy designing a template based on XHTML with borderless design.

I think you mean tableless

March 11th, 2004, 12:11 PM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Hehehe... typo...

#10

March 16th, 2004, 05:16 PM

master_rickster

Registered User

Join Date: May 2003

Posts: 14

Time spent in forums: 5 m 20 sec
Reputation Power: 0

Hey, that's pretty neat. What language is that?

#11

March 17th, 2004, 09:57 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Now all is still written with PHP in a design made with an IFRAME and lots of tables...
I'm busy on a new layout, you can check that one out at http://spongy.kicks-ass.org/xhtml/
As the URL reveals, written in XHTML with tableless design and all in PHP.
But I'm glad you liked it

Last edited by Spongy : March 18th, 2004 at 10:46 AM. Reason: Typo in the URL... SORRY GUYS

#12

March 17th, 2004, 12:54 PM

MadCowDzz

I'm Internet Famous

Join Date: Jan 2003

Location: Toronto, Canada

Posts: 2,890

Time spent in forums: 1 Week 16 h 14 m 9 sec
Reputation Power: 8

lol, deja vu!

Your site doesn't seem to load for me...
Are you sure you've typed the proper address?

and, um... when i took the /xhtml/ off the url, it passed me over to some adult site...

#13

March 18th, 2004, 10:46 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Oops... typo...

there must be a s after kick...
BIG SORRY!! I know it's a problem, but I think it's a bit funny... My parents were shocked when they forgot the s

but hey, here's the REAL PROPER address: http://spongy.kicks.ass.org/xhtml/
Sorry for the misstake

(The title of the page must be 'Spongy Kickin Yo Ass ::: something')

#14

March 18th, 2004, 10:51 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Quote:

Originally Posted by master_rickster

Hey, that's pretty neat. What language is that?

Uhm... Maybe you mean the actual language that people are reading...
It's Dutch. I keep a record of my 'adventures' abroad. I'm on a intership in Brest, France and this is a great way to keep my family and friends updated and I learn something on the way

Sorry if I didn't understand you well...

#15

March 23rd, 2004, 06:40 AM

stumpy

May contain nuts.

Join Date: Aug 2002

Location: Sydney, AU

Posts: 2,058

Time spent in forums: 5 h 8 m 57 sec
Reputation Power: 9

Hey spongy - your new site is starting to look good (code-wise). Good to see tableless, but you should shoot for more semantic markup. E.g. the navigation - both your nav menu's on the left are actually lists, and should be marked up as so:

Code:

<ul>
  <li><a href="foo.htm">Foo</a></li>
  <li><a href="blah.htm">Blah</a></li>
</ul>

The orange heading in the main content area is actually a heading - and should be marked up like this: "<h2>Welcome</h2>" (your H1 should be used for the top page title.)

#16

March 23rd, 2004, 07:44 AM

Spongy

Alternately High

Join Date: Feb 2004

Location: Hilversum, Netherlands

Posts: 223

Time spent in forums: 13 h 56 m 41 sec
Reputation Power: 5

Quote:

Originally Posted by stumpy

Code:

<ul>
  <li><a href="foo.htm">Foo</a></li>
  <li><a href="blah.htm">Blah</a></li>
</ul>

The orange heading in the main content area is actually a heading - and should be marked up like this: "<h2>Welcome</h2>" (your H1 should be used for the top page title.)

You mean the title-tag? And with the list thing, do I get those ugly dots in front of them? If so, I'll leave it as is...
Thx for the suggestions! And uh... I use multiple stylesheets which are randomly loaded... So it's not flowers everytime

But I'll see what I can do with your suggestions. Thanks again for the input.
Cheers,